-
Notifications
You must be signed in to change notification settings - Fork 90
feat: Reintroduce multiversion docs #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6aacbbd to
859172d
Compare
|
Weird - I don't see a "draft" option for this PR, maybe because |
bms63
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cicdguy!! Shall I merge this in now?
We have a new CRAN release on Jan 15 be great to work out any kinks before that
Not yet - I'll need to push the past versions into the |
Roger! I guess that is why you wanted to set it to DRAFT! Just ping me if you want a second set of eyes or to merge in. Thanks again for making this update - I know you are in high demand! |
|
I'll revisit this after the upcoming release. Do not want to disrupt anything that way. |
|
This Pull Request is stale because it has not been worked on in 15 days. |
|
@cicdguy think we can proceed with this PR now. admiral was released on January 15th with no issues identified...so far. |
|
Will the links not be an issue once this is merged into main - the ones with |
|
@bms63 - yes those links will all be updated. There's some other background work required to finish this end-to-end (re-provisioning older version on |
|
Update from @cicdguy: progress on this expected by end of month |
|
This Pull Request is stale because it has not been worked on in 15 days. |
|
This Pull Request is stale because it has not been worked on in 15 days. |
|
@cicdguy now that docs are built successfully, i guess this is almost done? 🙏 |
|
Almost ready to go. Just need to resolve an issue with Staged Dependencies for tag-based events. |
|
@cicdguy how is this going? |
|
Going good. Tests are running fine. We should be good to merge. |
|
Ok I'll resolve the conflicts and merge tomorrow if no other comments! Edit: conflicts already resolved |
|
Thanks @cicdguy 😄 |
Oh snap. I resolved it (I think). |
|
Hmm coverage still unhappy :( |
|
Darn, let me fix that. |
|
not sure if it's you, seeing it on other PRs |
|
Yeah it's my bad. Need to fix |
3eff678 to
ca8f9b6
Compare
|
Ok should be fixed now. |
okay to merge this in? we still will have dev version of site? |
|
Yes. Exactly |
|
@cicdguy thanks again!!! |
|
@cicdguy any chance we can not have |
|
Yes, change your tag/DESCRIPTION to the correct version: https://github.com/pharmaverse/admiral/blob/v1.2.0/DESCRIPTION#L4 v1.2.0 has 1.2.0.9000 in the DESCRIPTION file :) |
|
ah darn that is on me then. ummm.. |
|
@bms63 , I think there went something wrong. The older versions were removed and the |
|
@cicdguy could we get some pointers? I just modified the tag-v1.2.0 and then did a re-release on the updated tag. |
|
Ouch. Yeah that's bad. I'll look into it next week or so. |




Reintroduces the multiversion docs feature per @manciniedoardo's request.
The change was reverted in ee3e5b1 per @pharmaverse/admiral's decision.
This PR will reintroduce multiversion docs.
See examples where this is successfully used: