Skip to content

ci: remove upload documents from matrix job #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjaegers merged 2 commits into from
Oct 6, 2025
Merged

ci: remove upload documents from matrix job #959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9421c06
ci: remove upload documents from matrix job
rjaegers Oct 6, 2025
a4b4e88
chore: fix zizmor findings
rjaegers Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
apply-release-notes-template:
runs-on: ubuntu-latest
permissions:
# `contents: write` is needed to modify a release.
# Please note that this is an overly broad scope, but GitHub does not
# currently provide a more fine-grained permission for release modification.
contents: write
steps:
- uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
Expand All @@ -59,6 +62,9 @@
flavor: [cpp, rust]
runs-on: ubuntu-latest
permissions:
# `contents: write` is needed to modify a release.
# Please note that this is an overly broad scope, but GitHub does not
# currently provide a more fine-grained permission for release modification.
contents: write
needs: [build-push-test, apply-release-notes-template]
env:
Expand Down Expand Up @@ -90,16 +96,6 @@
GH_TOKEN: ${{ github.token }}
REPOSITORY_OWNER: ${{ github.repository_owner }}
REPOSITORY_NAME: ${{ github.event.repository.name }}
- uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
with:
pattern: documents
- name: Upload documents to release
run: |
set -Eeuo pipefail
gh release upload "${REF_NAME}" ./*.pdf
env:
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ github.token }}
- name: Update package details in release
run: |
set -Eeuo pipefail
Expand All @@ -111,3 +107,22 @@
DIGEST: ${{ steps.inspect-manifest.outputs.digest }}
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ github.token }}
upload-documents:
runs-on: ubuntu-latest
permissions:
# `contents: write` is needed to modify a release.
# Please note that this is an overly broad scope, but GitHub does not
# currently provide a more fine-grained permission for release modification.
contents: write

Check warning

Code scanning / zizmor

permissions without explanatory comments Warning

permissions without explanatory comments
needs: [build-push-test]
steps:
- uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
with:
pattern: documents
- name: Upload documents to release
run: |
set -Eeuo pipefail
gh release upload "${REF_NAME}" ./*.pdf
env:
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ github.token }}