Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 6, 2025

🚀 Hey, I have created a Pull Request

Description of changes

Document uploads as part of a release have been wrongfully added to the matrix job that runs for every container. Documents should only be uploaded once, so moved document upload to a separate job.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 6, 2025 06:29
Copilot AI review requested due to automatic review settings October 6, 2025 06:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Moves the document upload logic out of the per-matrix build job into a dedicated single-run job to prevent multiple redundant uploads on releases.

  • Removes document upload steps from the matrix job.
  • Adds a new upload-documents job that depends on build-push-test and performs a single release asset upload.

upload-documents:
runs-on: ubuntu-latest
permissions:
contents: write

Check warning

Code scanning / zizmor

permissions without explanatory comments Warning

permissions without explanatory comments
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.65s
✅ DOCKERFILE hadolint 2 0 0 0.88s
✅ GHERKIN gherkin-lint 6 0 0 2.41s
✅ JSON npm-package-json-lint yes no no 0.53s
✅ JSON prettier 15 2 0 0 0.55s
✅ JSON v8r 15 0 0 8.49s
✅ MARKDOWN markdownlint 10 0 0 0 0.96s
✅ MARKDOWN markdown-table-formatter 10 0 0 0 0.23s
✅ REPOSITORY gitleaks yes no no 0.63s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 28.74s
✅ REPOSITORY secretlint yes no no 1.06s
✅ REPOSITORY syft yes no no 2.06s
✅ REPOSITORY trivy yes no no 4.87s
✅ REPOSITORY trivy-sbom yes no no 0.26s
✅ REPOSITORY trufflehog yes no no 2.55s
✅ SPELL lychee 70 0 0 11.56s
✅ YAML prettier 26 0 0 0 0.8s
✅ YAML v8r 26 0 0 8.29s
✅ YAML yamllint 26 0 0 1.1s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-959

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 538.64 MB 538.65 MB +503 B (+0%) 🔼
linux/arm64 495.14 MB 495.15 MB +1.55 kB (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-959

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 692.84 MB 692.84 MB 242 B (0%) 🔽
linux/arm64 675.88 MB 675.88 MB +273 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Test Results

 5 files  ±0   5 suites  ±0   3m 50s ⏱️ +13s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a4b4e88. ± Comparison against base commit ab0940b.

♻️ This comment has been updated with latest results.

@magi-arun magi-arun requested a review from EkelmansPh October 6, 2025 07:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@rjaegers rjaegers added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 35f99f8 Oct 6, 2025
51 of 52 checks passed
@rjaegers rjaegers deleted the ci/dont-upload-documents-twice branch October 6, 2025 13:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Pull Request Report (#959)

Static measures

Description Value
Number of added lines 25
Number of deleted lines 10
Number of changed files 1
Number of commits 2
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 7.2 Hours
Time that was spend on the branch before the PR was created 1.6 Min
Time that was spend on the branch before the PR was merged 7.3 Hours
Time to merge after last review 6.5 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 37.2 Min
Total time spend in last status check run on PR 2.3 Hours

@github-actions
Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v6.5.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants