[PHP 7.4] replace uint-uint32_t, ulong-zend_ulong #5
Conversation
|
@Jan-E, thanks for the ping. Removal documented with php/php-src@571c6bc. The direct replacement of |
|
@cmb69 With respect to uint, I just copied what @weltling did in php/php-src@afb6ca2 And @remicollet Choose whatever new type you seem to be fitting best. |
| #if OAUTH_USE_CURL | ||
| static size_t soo_read_response(char *ptr, size_t size, size_t nmemb, void *ctx) /* {{{ */ | ||
| { | ||
| uint relsize; |
There was a problem hiding this comment.
This one should be size_t, as it is the result of multiplying two size_t's.
There was a problem hiding this comment.
OK! I will not modify the PR anymore, because I am not that familiar with the OAuth details. I will close the PR when a fix has been applied.
|
@Jan-E, using something more specific than |
|
From a not too deep look, the ulong -> zend_ulong replacements here look fine, and some might actually be fixing potential stack corruption bugs on Windows (where ulong* is passed bug zend_ulong* is expected). |
|
Closing this PR as it has conflicts with #7 |
3 participants
@remicollet @cmb69
In PHP 7.4 uint and ulong have been removed, although this is not mentioned in the upgrading notes.
This PR fixes compiling of the oauth extension.
See php/pecl-text-ereg#1 as well.