Skip to content

Fix GH-18617: socket_import_file_descriptor return check. #18618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-18617: socket_import_file_descriptor return check. #18618

wants to merge 2 commits into from

Conversation

@devnexen
Copy link
Member

to_zval_read_fd_array() helper when retrieving the socket protocol did not check it.

@devnexen devnexen marked this pull request as draft May 21, 2025 18:39
@devnexen
Fix phpGH-18617: socket_import_file_descriptor return check.
68338db 
to_zval_read_fd_array() helper when retrieving the socket protocol did
not check it.
@devnexen devnexen marked this pull request as ready for review May 21, 2025 18:52
@devnexen devnexen linked an issue May 21, 2025 that may be closed by this pull request
socket_import_file_descriptor return value not checked #18617
Closed
nielsdos
nielsdos reviewed May 21, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that more would be needed, but it seems the existing code already continues if something went wrong anyway and changing that may impact BC.
Anyway, don't you need to free up elem ?

@devnexen
Copy link
Member Author

Merged with c30bddc

@devnexen devnexen closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees

No one assigned

Labels

Extension: sockets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

socket_import_file_descriptor return value not checked

2 participants

@devnexen @nielsdos