Skip to content

Fix GH-18617: socket_import_file_descriptor return check. #18618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GH-18617: socket_import_file_descriptor return check. #18618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68338db
Fix GH-18617: socket_import_file_descriptor return check.
devnexen May 21, 2025
4d35405
free mem leak
devnexen May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/sockets/conversions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,7 +1457,11 @@ void to_zval_read_fd_array(const char *data, zval *zv, res_context *ctx)
object_init_ex(&elem, socket_ce);
php_socket *sock = Z_SOCKET_P(&elem);

socket_import_file_descriptor(fd, sock);
if (!socket_import_file_descriptor(fd, sock)) {
do_to_zval_err(ctx, "error getting protocol descriptor %d: getsockopt() call failed with errno %d", fd, errno);
zval_ptr_dtor(&elem);
return;
}
} else {
php_stream *stream = php_stream_fopen_from_fd(fd, "rw", NULL);
php_stream_to_zval(stream, &elem);
Expand Down
Loading