Fix line assignment in zend_ast_create_va() #18732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent here was to assign the first found line. Instead this always fell back to CG(zend_lineno). Not sure if this line matters for anything in php-src, but the issue was observed in nikic/php-ast#247.
iluuu1994
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
This indeed looks like an incorrect adaptation of the zend_ast_create_ functions. Thank you Nikita! Technically we could break once we enter the branch, but it's unlikely to matter in practice as the number of children is very low. Edit: Oh, nevermind. The loop does more than look for the lineno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent here was to assign the first found line. Instead this always fell back to CG(zend_lineno).
Not sure if this line matters for anything in php-src, but the issue was observed in nikic/php-ast#247.