Skip to content

[RFC] Deprecate curl_share_close() #19452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

[RFC] Deprecate curl_share_close() #19452

merged 1 commit into from
Aug 12, 2025
+12 −3

Conversation

DanielEScherzer
Copy link
Member

@DanielEScherzer
Copy link
Member Author

To avoid merge conflicts, NEWS/UPGRADING will be sent once this is approved

TimWolla
TimWolla reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but see #19451 (review).

@TimWolla TimWolla added the RFC label Aug 12, 2025
@DanielEScherzer DanielEScherzer merged commit 699e563 into php:master Aug 12, 2025
8 of 9 checks passed
@DanielEScherzer DanielEScherzer deleted the curl_share_close branch August 12, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

@Girgias Girgias Awaiting requested review from Girgias

Assignees
No one assigned
Labels
Extension: curl RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @TimWolla