Support classes of literal strings in RegexGroupParser #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
btw: I think the issue-bot is confused, as the result seem to be reporting wrong assertion errors |
|
That's because the issue-bot already posted comments from 1.12.x where the preg array shapes do not require bleeding edge. Here we're still running on 1.11.x. |
|
Thank you! |
mvorisek
reviewed
Aug 4, 2024
|
|
||
| function (string $s): void { | ||
| if (preg_match('/Price: (ba[rz])/i', $s, $matches)) { | ||
| assertType("array{string, 'bar'|'baz'}", $matches); |
There was a problem hiding this comment.
i modifier must be honored, ie. 'baR' must be present in the expected type
There was a problem hiding this comment.
At that point I'd fall back to not have literal strings at all. Too many combinations -> performance problems
There was a problem hiding this comment.
Yes, had the same thing in mind. Will fix.
Thanks
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support literals within classes for constant type inference.
I do intentionally not support constant types for classes which define "from-to" ranges like
a-zor0-9, as the semantics can get complex easily and the list of constant chars explodes pretty fast.