Don't infer constant types for "i"-modfied patterns #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
Thank you! |
mvorisek
reviewed
Aug 5, 2024
| RegexCapturingGroup|RegexNonCapturingGroup|null $parentGroup, | ||
| ): bool | ||
| { | ||
| if (str_contains($patternModifiers, 'i')) { |
There was a problem hiding this comment.
see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.61.1/src/DocBlock/TypeExpression.php#L58 regex, modifiers does not have to be global
There was a problem hiding this comment.
most helpful would be a issue report with a reproducing snippet.
but I am already working on this one, so thanks for the heads up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it likely yields too many combinations as discussed in #3285 (comment)