Skip to content

Fix a few regex class parsing usecases #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 6, 2024
Merged

Fix a few regex class parsing usecases #3488

merged 8 commits into from
Oct 6, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Sep 26, 2024 •
edited
Loading

No description provided.

@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch 3 times, most recently from b069a8b to dc514ed Compare September 26, 2024 11:52
@mvorisek mvorisek marked this pull request as ready for review September 26, 2024 12:04
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

mvorisek
mvorisek commented Sep 26, 2024
View reviewed changes
@mvorisek mvorisek marked this pull request as draft September 26, 2024 17:11
staabm
staabm reviewed Sep 26, 2024
View reviewed changes
@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch from dc514ed to 1c53889 Compare September 26, 2024 18:34
@mvorisek mvorisek changed the title Fix delimiter unescape when removing from regex Add a few backslash regex tests Sep 26, 2024
@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch from 1c53889 to 55509d5 Compare September 26, 2024 22:36
@mvorisek mvorisek changed the title Add a few backslash regex tests Fix "]" first char parsing in class regex Sep 26, 2024
@mvorisek mvorisek marked this pull request as ready for review September 26, 2024 22:38
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@mvorisek mvorisek requested a review from staabm September 26, 2024 22:39
@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch 2 times, most recently from 6c07966 to 93e2709 Compare September 26, 2024 23:14
staabm
staabm reviewed Sep 27, 2024
View reviewed changes
staabm
staabm reviewed Sep 27, 2024
View reviewed changes
staabm
staabm reviewed Sep 27, 2024
View reviewed changes
staabm
staabm reviewed Sep 27, 2024
View reviewed changes
Seldaek
Seldaek reviewed Sep 27, 2024
View reviewed changes
Seldaek
Seldaek reviewed Sep 27, 2024
View reviewed changes
Seldaek
Seldaek reviewed Sep 27, 2024
View reviewed changes
Seldaek
Seldaek reviewed Sep 27, 2024
View reviewed changes
Seldaek
Seldaek approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Seldaek Seldaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the two tests that should be changed and bug fixed (but maybe @staabm can take a look in a follow-up PR as he's probably more familiar with that code), the changes here look good to me now 👍🏻

@mvorisek mvorisek changed the title Fix "]" first char parsing in class regex Fix a few regex class parsing usecases Sep 27, 2024
@Seldaek
Copy link
Contributor

Seldaek commented Sep 27, 2024

Cool, thanks for the last couple fixes 👍🏻

@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch from 53a37a0 to 64562d9 Compare September 27, 2024 11:06
staabm
staabm approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

This was referenced Sep 27, 2024
Closed
Merged
@mvorisek
Copy link
Contributor Author

@ondrejmirtes can this PR be merged?

@ondrejmirtes
Copy link
Member

@mvorisek It's been only 4 days since you opened it. Don't be needy.

@ondrejmirtes ondrejmirtes merged commit a9ec512 into phpstan:1.12.x Oct 6, 2024
481 of 499 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@mvorisek mvorisek deleted the fix_delim_remove_regex branch October 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@staabm staabm staabm approved these changes

@Seldaek Seldaek Seldaek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mvorisek @phpstan-bot @Seldaek @ondrejmirtes @staabm