Add error reporting for unresolvable types in @phpstan-assert tags

[zonuexe]

Fix phpstan/phpstan#11780

[ondrejmirtes]

Better fit would be to add it to AssertRuleHelper. We need to check for:

• Nonexistent classes and traits, like here:

  phpstan-src/src/Rules/FunctionDefinitionCheck.php

  Lines 157 to 179 in b009a44

  	if (!$this->reflectionProvider->hasClass($class)) {
  	$errors[] = RuleErrorBuilder::message(sprintf($parameterMessage, $param->var->name, $class))
  	->line($param->type->getStartLine())
  	->identifier('class.notFound')
  	->build();
  	continue;
  	}
  	$classReflection = $this->reflectionProvider->getClass($class);
  	if ($classReflection->isTrait()) {
  	$errors[] = RuleErrorBuilder::message(sprintf($parameterMessage, $param->var->name, $class))
  	->line($param->type->getStartLine())
  	->identifier('parameter.trait')
  	->build();
  	continue;
  	}
  	$errors = array_merge(
  	$errors,
  	$this->classCheck->checkClassNames([
  	new ClassNameNodePair($class, $param->type),
  	], $this->checkClassCaseSensitivity),
  	);

• Unresolvable types, like here:

  phpstan-src/src/Rules/PhpDoc/IncompatiblePhpDocTypeRule.php

  Lines 84 to 91 in b009a44

  	} elseif (
  	$this->unresolvableTypeHelper->containsUnresolvableType($phpDocParamType)
  	) {
  	$errors[] = RuleErrorBuilder::message(sprintf(
  	'PHPDoc tag %s for parameter $%s contains unresolvable type.',
  	$tagName,
  	$parameterName,
  	))->identifier('parameter.unresolvableType')->build();

• Missing types, like here:

  phpstan-src/src/Rules/Classes/MixinCheck.php

  Lines 71 to 101 in b009a44

  	foreach ($this->missingTypehintCheck->getIterableTypesWithMissingValueTypehint($type) as $iterableType) {
  	$iterableTypeDescription = $iterableType->describe(VerbosityLevel::typeOnly());
  	$errors[] = RuleErrorBuilder::message(sprintf(
  	'%s %s has PHPDoc tag @mixin with no value type specified in iterable type %s.',
  	$classReflection->getClassTypeDescription(),
  	$classReflection->getDisplayName(),
  	$iterableTypeDescription,
  	))
  	->tip(MissingTypehintCheck::MISSING_ITERABLE_VALUE_TYPE_TIP)
  	->identifier('missingType.iterableValue')
  	->build();
  	}
  	foreach ($this->missingTypehintCheck->getNonGenericObjectTypesWithGenericClass($type) as [$innerName, $genericTypeNames]) {
  	$errors[] = RuleErrorBuilder::message(sprintf(
  	'PHPDoc tag @mixin contains generic %s but does not specify its types: %s',
  	$innerName,
  	implode(', ', $genericTypeNames),
  	))
  	->identifier('missingType.generics')
  	->build();
  	}
  	foreach ($this->missingTypehintCheck->getCallablesWithMissingSignature($type) as $callableType) {
  	$errors[] = RuleErrorBuilder::message(sprintf(
  	'%s %s has PHPDoc tag @mixin with no signature specified for %s.',
  	$classReflection->getClassTypeDescription(),
  	$classReflection->getDisplayName(),
  	$callableType->describe(VerbosityLevel::typeOnly()),
  	))->identifier('missingType.callable')->build();
  	}

• Generics, like here:

  phpstan-src/src/Rules/Classes/MixinCheck.php

  Lines 137 to 145 in b009a44

  	$errors = array_merge($errors, $this->genericObjectTypeCheck->check(
  	$type,
  	'PHPDoc tag @mixin contains generic type %s but %s %s is not generic.',
  	'Generic type %s in PHPDoc tag @mixin does not specify all template types of %s %s: %s',
  	'Generic type %s in PHPDoc tag @mixin specifies %d template types, but %s %s supports only %d: %s',
  	'Type %s in generic type %s in PHPDoc tag @mixin is not subtype of template type %s of %s %s.',
  	'Call-site variance of %s in generic type %s in PHPDoc tag @mixin is in conflict with %s template type %s of %s %s.',
  	'Call-site variance of %s in generic type %s in PHPDoc tag @mixin is redundant, template type %s of %s %s has the same variance.',
  	));

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Call UnresolvableTypeHelper instead please. You should follow the code samples I sent you :)

[ondrejmirtes]

Also please add all the other things that should be checked too.

[ondrejmirtes]

I'm sorry, I'm in a bit of a hurry, finishing this myself.

[ondrejmirtes]

Superseded by ca0a7e9