Add error reporting for unresolvable types in @phpstan-assert tags

src/Rules/PhpDoc/AssertRuleHelper.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\PhpDoc;
 
+use PHPStan\PhpDoc\Tag\AssertTag;
 use PHPStan\Node\Expr\TypeExpr;
 use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\FunctionReflection;
@@ -20,7 +21,10 @@
 final class AssertRuleHelper
 {
 
-	public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver)
+	public function __construct(
+		private InitializerExprTypeResolver $initializerExprTypeResolver,
+		private UnresolvableTypeHelper $unresolvableTypeHelper,
+	)
 	{
 	}
 
@@ -55,9 +59,25 @@ public function check(ExtendedMethodReflection|FunctionReflection $reflection, P
 				continue;
 			}
 
+			if ($this->unresolvableTypeHelper->containsUnresolvableType($assert->getType())) {
+				$tagName = [
+					AssertTag::NULL => '@phpstan-assert',
+					AssertTag::IF_TRUE => '@phpstan-assert-if-true',
+					AssertTag::IF_FALSE => '@phpstan-assert-if-false',
+				][$assert->getIf()];
+
+				$errors[] = RuleErrorBuilder::message(sprintf(
+					'PHPDoc tag %s for parameter $%s contains unresolvable type.',
+					$tagName,
+					$parameterName,
+				))->identifier('parameter.unresolvableType')->build();
+
+				continue;
+			}
+
 			$assertedExpr = $assert->getParameter()->getExpr(new TypeExpr($parametersByName[$parameterName]));
 			$assertedExprType = $this->initializerExprTypeResolver->getType($assertedExpr, $context);
-			if ($assertedExprType instanceof ErrorType) {
+			if ($this->unresolvableTypeHelper->containsUnresolvableType($assertedExprType)) {
 				continue;
 			}
 

tests/PHPStan/Rules/PhpDoc/FunctionAssertRuleTest.php

@@ -15,7 +15,7 @@
 	protected function getRule(): Rule
 	{
 		$initializerExprTypeResolver = self::getContainer()->getByType(InitializerExprTypeResolver::class);
 		return new FunctionAssertRule(new AssertRuleHelper($initializerExprTypeResolver));
 	}
 
 	public function testRule(): void
@@ -54,6 +54,18 @@
 				'Asserted negated type string for $i with type int does not narrow down the type.',
 				70,
 			],
+			[
+				'PHPDoc tag @phpstan-assert for parameter $str contains unresolvable type.',
+				83,
+			],
+			[
+				'PHPDoc tag @phpstan-assert-if-true for parameter $str contains unresolvable type.',
+				90,
+],
+			[
+				'PHPDoc tag @phpstan-assert-if-false for parameter $str contains unresolvable type.',
+				97,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/PhpDoc/MethodAssertRuleTest.php

@@ -15,7 +15,7 @@
 	protected function getRule(): Rule
 	{
 		$initializerExprTypeResolver = self::getContainer()->getByType(InitializerExprTypeResolver::class);
 		return new MethodAssertRule(new AssertRuleHelper($initializerExprTypeResolver));
 	}
 
 	public function testRule(): void
@@ -54,6 +54,18 @@
 				'Asserted negated type string for $i with type int does not narrow down the type.',
 				72,
 			],
+			[
+				'PHPDoc tag @phpstan-assert for parameter $str contains unresolvable type.',
+				86,
+			],
+			[
+				'PHPDoc tag @phpstan-assert-if-true for parameter $str contains unresolvable type.',
+				93,
+],
+			[
+				'PHPDoc tag @phpstan-assert-if-false for parameter $str contains unresolvable type.',
+				100,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/PhpDoc/data/function-assert.php

@@ -76,3 +76,24 @@ function negate1(int $i): void
 function negate2(int $i): void
 {
 }
+
+/**
+ * @phpstan-assert empty-str $str
+ */
+function unresolvableAssert(string $str): void
+{
+}
+
+/**
+ * @phpstan-assert-if-true empty-str $str
+ */
+function unresolvableAssertIfTrue(string $str): void
+{
+}
+
+/**
+ * @phpstan-assert-if-false empty-str $str
+ */
+function unresolvableAssertIfFalse(string $str): void
+{
+}

tests/PHPStan/Rules/PhpDoc/data/method-assert.php

@@ -79,4 +79,26 @@ public function negate1(int $i): void
 	public function negate2(int $i): void
 	{
 	}
+
+	/**
+	 * @phpstan-assert empty-str $str
+	 */
+	public function unresolvableAssert(string $str): void
+	{
+	}
+
+	/**
+	 * @phpstan-assert-if-true empty-str $str
+	 */
+	public function unresolvableAssertIfTrue(string $str): void
+	{
+	}
+
+	/**
+	 * @phpstan-assert-if-false empty-str $str
+	 */
+	public function unresolvableAssertIfFalse(string $str): void
+	{
+	}
+
 }