Test loose comparison on constant types #3755
Merged
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
constloose
branch
3 times, most recently
from
4db6522 to
9e3d1d3
Compare
staabm
commented
Dec 25, 2024
Comment on lines
+663
to
+765
| assertType('false', 5 == $emptyStr); | ||
| assertType('false', 5 == $phpStr); | ||
| assertType('false', 5 == 'a'); | ||
|
|
||
| assertType('false', $emptyStr == 5); | ||
| assertType('false', $phpStr == 5); | ||
| assertType('false', 'a' == 5); |
There was a problem hiding this comment.
staabm
commented
Dec 25, 2024
| if ($this->isIterableAtLeastOnce()->no() && count($type->getConstantScalarValues()) === 1) { | ||
| // @phpstan-ignore equal.invalid, equal.notAllowed | ||
| return new ConstantBooleanType($type->getConstantScalarValues()[0] == []); // phpcs:ignore | ||
| if ($type->isInteger()->yes()) { |
There was a problem hiding this comment.
mirrored from ArrayType
staabm
force-pushed
the
constloose
branch
3 times, most recently
from
a85f37a to
6fcbe71
Compare
staabm
commented
Dec 25, 2024
Comment on lines
+720
to
+828
| assertType('false', $emptyArr == $looseOne); | ||
| assertType('bool', $emptyArr == $constMix); | ||
| assertType('bool', $emptyArr == $looseZero); |
There was a problem hiding this comment.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.