Skip to content

Test loose comparison on constant types #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Test loose comparison on constant types #3755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/Type/Constant/ConstantArrayType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,25 @@ public function isSuperTypeOf(Type $type): IsSuperTypeOfResult

public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType
{
if ($this->isIterableAtLeastOnce()->no() && count($type->getConstantScalarValues()) === 1) {
// @phpstan-ignore equal.invalid, equal.notAllowed
return new ConstantBooleanType($type->getConstantScalarValues()[0] == []); // phpcs:ignore
if ($type->isInteger()->yes()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mirrored from ArrayType

return new ConstantBooleanType(false);
}

if ($this->isIterableAtLeastOnce()->no()) {
if ($type->isIterableAtLeastOnce()->yes()) {
return new ConstantBooleanType(false);
}

$constantScalarValues = $type->getConstantScalarValues();
if (count($constantScalarValues) > 0) {
$results = [];
foreach ($constantScalarValues as $constantScalarValue) {
// @phpstan-ignore equal.invalid, equal.notAllowed
$results[] = TrinaryLogic::createFromBoolean($constantScalarValue == []); // phpcs:ignore
}

return TrinaryLogic::extremeIdentity(...$results)->toBooleanType();
}
}

return new BooleanType();
Expand Down
45 changes: 44 additions & 1 deletion tests/PHPStan/Analyser/nsrt/loose-comparisons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,8 @@ public function sayInt(
array $array,
int $int,
int $intRange,
string $emptyStr,
string $phpStr,
): void
{
assertType('bool', $int == $true);
Expand All @@ -747,19 +749,37 @@ public function sayInt(
assertType('false', $intRange == $emptyArr);
assertType('false', $intRange == $array);

assertType('false', 5 == $emptyArr);
assertType('false', $emptyArr == 5);
assertType('false', 5 == $array);
assertType('false', $array == 5);
assertType('false', [] == 5);
assertType('false', 5 == []);

assertType('false', 5 == $emptyStr);
assertType('false', 5 == $phpStr);
assertType('false', 5 == 'a');

assertType('false', $emptyStr == 5);
assertType('false', $phpStr == 5);
assertType('false', 'a' == 5);
Comment on lines +759 to +765
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://3v4l.org/mX8s9

}

/**
* @param true|1|"1" $looseOne
* @param false|0|"0" $looseZero
* @param false|1 $constMix
* @param "abc"|"def" $constNonFalsy
* @param array{abc: string, num?: int, nullable: ?string} $arrShape
* @param array{} $emptyArr
*/
public function sayConstUnion(
$looseOne,
$looseZero,
$constMix,
$constNonFalsy,
array $arrShape,
array $emptyArr
): void
{
assertType('true', $looseOne == 1);
Expand Down Expand Up @@ -802,13 +822,22 @@ public function sayConstUnion(
assertType('false', $constNonFalsy == "1");
assertType('false', $constNonFalsy == "0");
assertType('false', $constNonFalsy == []);

assertType('false', $emptyArr == $looseOne);
assertType('bool', $emptyArr == $constMix);
assertType('bool', $emptyArr == $looseZero);
Comment on lines +826 to +828
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://3v4l.org/3tReg


assertType('bool', $arrShape == $looseOne);
assertType('bool', $arrShape == $constMix);
assertType('bool', $arrShape == $looseZero);
}

/**
* @param uppercase-string $upper
* @param lowercase-string $lower
* @param array{} $emptyArr
* @param non-empty-array $nonEmptyArr
* @param array{abc: string, num?: int, nullable: ?string} $arrShape
* @param int<10, 20> $intRange
*/
public function sayIntersection(
Expand All @@ -818,6 +847,7 @@ public function sayIntersection(
array $emptyArr,
array $nonEmptyArr,
array $arr,
array $arrShape,
int $i,
int $intRange,
): void
Expand Down Expand Up @@ -849,11 +879,24 @@ public function sayIntersection(
assertType('false', $nonEmptyArr == $i);
assertType('false', $arr == $intRange);
assertType('false', $nonEmptyArr == $intRange);
assertType('bool', $emptyArr == $nonEmptyArr); // should be false
assertType('false', $emptyArr == $nonEmptyArr);
assertType('false', $nonEmptyArr == $emptyArr);
assertType('bool', $arr == $nonEmptyArr);
assertType('bool', $nonEmptyArr == $arr);

assertType('false', 5 == $arr);
assertType('false', $arr == 5);
assertType('false', 5 == $emptyArr);
assertType('false', $emptyArr == 5);
assertType('false', 5 == $nonEmptyArr);
assertType('false', $nonEmptyArr == 5);
assertType('false', 5 == $arrShape);
assertType('false', $arrShape == 5);
if (count($arr) > 0) {
assertType('false', 5 == $arr);
assertType('false', $arr == 5);
}

assertType('bool', '' == $lower);
if ($lower != '') {
assertType('false', '' == $lower);
Expand Down
Loading