feat: cache the result of ClassReflection::hasMethod method #3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
force-pushed
the
has-method-cache
branch
from
52fe8f4 to
f819a4a
Compare
ondrejmirtes
requested changes
Feb 13, 2025
canvural
force-pushed
the
has-method-cache
branch
from
f819a4a to
a2c8942
Compare
canvural
force-pushed
the
has-method-cache
branch
from
a2c8942 to
10a1e9d
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏽
This PR caches the result of the
ClassReflection::hasMethodmethod. While investigating some performance issues I found that PHPStan calls method class reflection extensions multiple times for the same class and method. And some extensions might do the actual work inhasMethodmethod rather thangetMethod, for example Larastan does this to cache stuff internally.I can add tests if wanted. Couldn't think of an easy way to do it right away 😅