Skip to content

feat: cache the result of ClassReflection::hasMethod method #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: cache the result of ClassReflection::hasMethod method #3825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Reflection/ClassReflection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ class ClassReflection
/** @var array<string, true> */
private static array $resolvingTypeAliasImports = [];

/** @var array<string, bool> */
private array $hasMethodCache = [];

/**
* @param PropertiesClassReflectionExtension[] $propertiesClassReflectionExtensions
* @param MethodsClassReflectionExtension[] $methodsClassReflectionExtensions
Expand Down Expand Up @@ -482,16 +485,26 @@ public function hasProperty(string $propertyName): bool

public function hasMethod(string $methodName): bool
{
if (array_key_exists($methodName, $this->hasMethodCache)) {
return $this->hasMethodCache[$methodName];
}

foreach ($this->methodsClassReflectionExtensions as $extension) {
if ($extension->hasMethod($this, $methodName)) {
$this->hasMethodCache[$methodName] = true;

return true;
}
}

if ($this->requireExtendsMethodsClassReflectionExtension->hasMethod($this, $methodName)) {
$this->hasMethodCache[$methodName] = true;

return true;
}

$this->hasMethodCache[$methodName] = false;

return false;
}

Expand Down
Loading