Skip to content

RegexGroupParser - cache regex parsing results #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 22, 2025

running https://github.com/phpstan/phpstan-src/blob/327ac3e54bd04d85aec3af9f893f8e3e8f38af7d/tests/PHPStan/Analyser/nsrt/preg_match_shapes.php

before this PR

➜  phpstan-src git:(2.1.x) ✗ hyperfine 'php bin/phpstan analyze test.php --debug' -i
Benchmark 1: php bin/phpstan analyze test.php --debug
  Time (mean ± σ):      1.677 s ±  0.007 s    [User: 1.563 s, System: 0.110 s]
  Range (min … max):    1.666 s …  1.685 s    10 runs

after this PR

➜  phpstan-src git:(2.1.x) ✗ hyperfine 'php bin/phpstan analyze test.php --debug' -i
Benchmark 1: php bin/phpstan analyze test.php --debug
  Time (mean ± σ):      1.280 s ±  0.018 s    [User: 1.165 s, System: 0.111 s]
  Range (min … max):    1.264 s …  1.311 s    10 runs

@staabm
Copy link
Contributor Author

staabm commented Mar 22, 2025

needs more immutability

@staabm staabm closed this Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant