RegexGroupParser - cache regex parsing results

src/Type/Regex/RegexGroupParser.php

@@ -20,6 +20,7 @@
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
+use function array_key_exists;
 use function array_values;
 use function count;
 use function in_array;
@@ -42,6 +43,9 @@
 
 	private static ?Parser $parser = null;
 
+	/** @var array<string, array{array<int, RegexCapturingGroup>, list<string>}|null> */
+	private static array $resultCache = [];
+
 	public function __construct(
 		private PhpVersion $phpVersion,
 		private RegexExpressionHelper $regexExpressionHelper,
@@ -53,6 +57,18 @@
 	 * @return array{array<int, RegexCapturingGroup>, list<string>}|null
 	 */
 	public function parseGroups(string $regex): ?array
+	{
+		if (array_key_exists($regex, self::$resultCache)) {
+			return self::$resultCache[$regex];
+		}
+
+		return self::$resultCache[$regex] = $this->parse($regex);
+	}
+
+	/**
+	 * @return array{array<int, RegexCapturingGroup>, list<string>}|null
+	 */
+	private function parse(string $regex): ?array
 	{
 		if (self::$parser === null) {
 			/** @throws void */
@@ -236,7 +252,7 @@
 		}
 
 		if ($ast->getId() === '#mark') {
 			return $astWalkResult->markVerb($ast->getChild(0)->getValueValue());
 		}
 
 		if (
@@ -246,7 +262,7 @@
 			$astWalkResult = $astWalkResult->addCapturingGroup($group);
 
 			if ($alternation !== null) {
-				$alternation->pushGroup($combinationIndex, $group);
+				$alternation = $alternation->pushGroup($combinationIndex, $group);
 			}
 		}