Add non regression test for 4284 #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

VincentLanglet wants to merge 1 commit into phpstan:2.1.x from VincentLanglet:fix/4284

Contributor

VincentLanglet commented Jul 27, 2025

Closes phpstan/phpstan#4284

https://phpstan.org/r/dc24e5cb-ca3c-45f5-a49e-7425604e7ac9 is understood.


          Add non regression test

98d04a4

Member

ondrejmirtes commented Aug 30, 2025

I'd expect the opposite. If $browserName is truthy then $upgradeBrowserLink is truthy as well. PHPStan should detect that in both conditions.

ondrejmirtes closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet