Skip to content

Add non regression test for 4284 #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add non regression test for 4284 #4177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/PHPStan/Rules/Comparison/BooleanAndConstantConditionRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,13 @@ public function testReportAlwaysTrueInLastCondition(bool $reportAlwaysTrueInLast
$this->analyse([__DIR__ . '/data/boolean-and-report-always-true-last-condition.php'], $expectedErrors);
}

public function testBug4284(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->reportAlwaysTrueInLastCondition = true;
$this->analyse([__DIR__ . '/data/bug-4284.php'], []);
}

public function testBug5365(): void
{
$this->treatPhpDocTypesAsCertain = true;
Expand Down
30 changes: 30 additions & 0 deletions tests/PHPStan/Rules/Comparison/data/bug-4284.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php declare(strict_types = 1);

namespace Bug4284;

class HelloWorld
{
/** @param mixed[] $browser */
public function sayHello(array $browser): void
{
$browserName = '';
$upgradeBrowserLink = '';

if ($browser['name'] === 1) {
$browserName = '123';
$upgradeBrowserLink = '456';
} elseif ($browser['name'] === 2) {
$browserName = '789';
$upgradeBrowserLink = '123';
}

if ($browserName && $upgradeBrowserLink) {
//
}
if ($browserName) {
if ($upgradeBrowserLink) {
//
}
}
}
}
Loading