Added proc_open() stub for param-out #4261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
mvorisek
reviewed
Aug 27, 2025
ondrejmirtes
requested changes
Aug 30, 2025
There was a problem hiding this comment.
You're closing an issue, please add a regression test for https://phpstan.org/r/dc1d4f91-b22d-4eaa-b796-34a353062477
|
(I don't think the issue is solved so that's why I'm asking for a test for the new behaviour) |
|
@ondrejmirtes test added. I think it works. |
mvorisek
reviewed
Aug 30, 2025
mvorisek
reviewed
Sep 2, 2025
mvorisek
reviewed
Sep 2, 2025
staabm
force-pushed
the
proc
branch
3 times, most recently
from
2a59579 to
02f3727
Compare
staabm
force-pushed
the
proc
branch
2 times, most recently
from
71a89e4 to
5bf9a1d
Compare
Co-authored-by: Michael Voříšek <[email protected]>
Co-authored-by: Michael Voříšek <[email protected]>
|
Thank you @staabm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13197
closes phpstan/phpstan#11777