-
Notifications
You must be signed in to change notification settings - Fork 542
Added proc_open() stub for param-out #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
038de1b
Added proc_open() stub for param-out
staabm 91a6453
fix types
staabm 2bcbb84
iterable types
staabm 8632690
fix php 7.4
staabm 7c51941
Update core.stub
staabm ecd69df
regression test
staabm 4b376e0
more precise types
staabm 9e0c997
simplify
staabm 98d52b3
defaults
staabm 1592b6d
comments
staabm d2712cf
added regression test
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace Bug13197; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
/** | ||
* @return array{string, string}|null STDOUT & STDERR tuple | ||
*/ | ||
function execute(string $command): ?array | ||
{ | ||
if (!function_exists('proc_open')) { | ||
return null; | ||
} | ||
|
||
$pipes = []; | ||
|
||
$process = @proc_open( | ||
$command, | ||
[ | ||
['pipe', 'rb'], | ||
['pipe', 'wb'], // stdout | ||
['pipe', 'wb'], // stderr | ||
], | ||
$pipes | ||
); | ||
|
||
assertType('array<0|1|2, resource>', $pipes); | ||
|
||
if (!is_resource($process)) { | ||
return null; | ||
} | ||
|
||
fclose($pipes[0]); | ||
|
||
$stdout = (string) stream_get_contents($pipes[1]); | ||
$stderr = (string) stream_get_contents($pipes[2]); | ||
|
||
proc_close($process); | ||
|
||
return [$stdout, $stderr]; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace Bug13197b; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
function execute(string $command): void | ||
{ | ||
if (!function_exists('proc_open')) { | ||
return; | ||
} | ||
|
||
$pipes = []; | ||
|
||
$process = @proc_open( | ||
$command, | ||
[ | ||
['pipe', 'rb'], | ||
3 => ['pipe', 'wb'], // https://stackoverflow.com/questions/28909347/is-it-possible-to-connect-more-than-the-two-standard-streams-to-a-terminal-in-li#28909376 | ||
5 => ['pipe', 'wb'], | ||
], | ||
$pipes | ||
); | ||
|
||
assertType('array<0|3|5, resource>', $pipes); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?php | ||
|
||
namespace Bug11777; | ||
|
||
class HelloWorld { | ||
/** @var array<int, resource> */ | ||
private array $pipes; | ||
|
||
public function sayHello(string $cmd): void { | ||
proc_open($cmd, [0 => ['pipe', 'r']], $this->pipes); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.