Increment on non-numeric string is deprecated, use str_increment() instead #4262
+85
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Aug 26, 2025
src/Analyser/MutatingScope.php
Outdated
| @@ -1733,10 +1736,18 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu | |||
| foreach ($varScalars as $varValue) { | |||
| if ($node instanceof Expr\PreInc) { | |||
| if (!is_bool($varValue)) { | |||
| ++$varValue; | |||
| if (function_exists('str_increment')) { | |||
| $varValue = str_increment($varValue); | |||
|
I think there is room for improvement for PHP 8.5.x |
|
Awesome 👍 |
staabm
force-pushed
the
depr
branch
2 times, most recently
from
1ad1b73 to
4d86d46
Compare
|
This pull request has been marked as ready for review. |
staabm
commented
Aug 28, 2025
Comment on lines
+1737
to
+1738
| if ($varValue === '') { | ||
| $varValue = '1'; |
There was a problem hiding this comment.
neither ++$varValue nor str_increment($varValue) is allowed on PHP 8.5 when $varValue is a empty string.
therefore we hardcode the value which this operation lead to when PHP < 8.5
There was a problem hiding this comment.
And what about non-empty strings? This PR initially handled that but does not anymore.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PHP 8.5 deprecations like