Skip to content

Increment on non-numeric string is deprecated, use str_increment() instead #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 30, 2025
+85 −3
Merged

Increment on non-numeric string is deprecated, use str_increment() instead #4262

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b5b0bd
Increment on non-numeric string is deprecated, use str_increment() in…
staabm Aug 26, 2025
7c2e84a
Update MutatingScope.php
staabm Aug 26, 2025
5f0139d
fix
staabm Aug 28, 2025
1e60552
try smaller fix
staabm Aug 28, 2025
bac6284
fix deprecations / add tests
staabm Aug 29, 2025
3d293c3
fix build on php < 8.3
staabm Aug 29, 2025
b28e301
fix type
staabm Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Analyser/MutatingScope.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,7 +1732,11 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu

foreach ($varScalars as $varValue) {
if ($node instanceof Expr\PreInc) {
if (!is_bool($varValue)) {
// until PHP 8.5 it was valid to increment an empty string.
// see https://github.com/php/php-src/issues/19597
if ($varValue === '') {
$varValue = '1';
Comment on lines +1739 to +1740
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither ++$varValue nor str_increment($varValue) is allowed on PHP 8.5 when $varValue is a empty string.

therefore we hardcode the value which this operation lead to when PHP < 8.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about non-empty strings? This PR initially handled that but does not anymore.

} elseif (!is_bool($varValue)) {
++$varValue;
}
} elseif (is_numeric($varValue)) {
Expand Down
Loading