Fix duplicate work in AnnotationsPropertiesClassReflectionExtension->findClassReflectionWithProperty() #4268
Conversation
…findClassReflectionWithProperty()
| @@ -81,13 +81,11 @@ private function findClassReflectionWithProperty( | |||
| } | |||
|
|
|||
| $parentClass = $classReflection->getParentClass(); | |||
| while ($parentClass !== null) { | |||
| if ($parentClass !== null) { | |||
| $methodWithDeclaringClass = $this->findClassReflectionWithProperty($parentClass, $parentClass, $propertyName); | |||
There was a problem hiding this comment.
this recursive call will already work its way to the top parent class. we don't need another loop thru all parents.
see how the number of calls increased on each parent class before this PR:
|
This pull request has been marked as ready for review. |
|
The reproduction repo https://github.com/verfriemelt-dot-org/coverage-fail looks useful. Please copy the directory structure to e2e/ and try to run the analysis in E2E tests. |
|
added the e2e test with a timeout. I don't think it makes much sense to put expectations on the output of found errors. |
| @@ -392,6 +392,9 @@ jobs: | |||
| cd e2e/composer-version-config | |||
| composer install | |||
| ../../bin/phpstan analyze test.php --level=0 | |||
| - script: | | |||
| cd e2e/bug13425 | |||
| timeout 15 ../bashunit -a exit_code "1" "../../bin/phpstan analyze src/ plugins/" | |||
There was a problem hiding this comment.
I couldn't find where is this timeout command coming from?
There was a problem hiding this comment.
its a linux command line tool, usually contained in stock installations.
brew install coreutils installs it on macos
|
Thank you! |
closes phpstan/phpstan#13425