Skip to content

Fix duplicate work in AnnotationsPropertiesClassReflectionExtension->findClassReflectionWithProperty() #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 30, 2025
Merged

Fix duplicate work in AnnotationsPropertiesClassReflectionExtension->findClassReflectionWithProperty() #4268

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec60161
Fix duplicate work in AnnotationsPropertiesClassReflectionExtension->…
staabm Aug 29, 2025
8c9ba03
analog fix in AnnotationsMethodsClassReflectionExtension
staabm Aug 29, 2025
b556528
analog fix in Mixin*ReflectionExtensions
staabm Aug 29, 2025
a9d3785
added test
staabm Aug 29, 2025
83ba747
Update e2e-tests.yml
staabm Aug 29, 2025
fa7fbf6
Update e2e-tests.yml
staabm Aug 29, 2025
776fd33
Update e2e-tests.yml
staabm Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,11 @@ private function findClassReflectionWithProperty(
}

$parentClass = $classReflection->getParentClass();
while ($parentClass !== null) {
if ($parentClass !== null) {
$methodWithDeclaringClass = $this->findClassReflectionWithProperty($parentClass, $parentClass, $propertyName);
Copy link
Contributor Author

@staabm staabm Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this recursive call will already work its way to the top parent class. we don't need another loop thru all parents.

see how the number of calls increased on each parent class before this PR:

grafik

if ($methodWithDeclaringClass !== null) {
return $methodWithDeclaringClass;
}

$parentClass = $parentClass->getParentClass();
}

foreach ($classReflection->getInterfaces() as $interfaceClass) {
Expand Down
Loading