Skip to content

fix(cli): CLI do not exit with 0 on pull when branch does not exist #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BlumMichael merged 2 commits into from
Jan 15, 2025
Merged

fix(cli): CLI do not exit with 0 on pull when branch does not exist #768

BlumMichael merged 2 commits into from
Jan 15, 2025

Conversation

@BlumMichael
Copy link
Contributor

@BlumMichael BlumMichael commented Jan 15, 2025 •
edited
Loading

  • When using pull command with branch param and the requested branch does not exist, answer with exit-code 1 instead of 0.
  • Also adds an error message

Issue

See Screenshot

image

@BlumMichael BlumMichael changed the title Strings 564 cli do not exist with 0 on pull when branch does not exist Fix (STRINGS-564) - CLI do not exit with 0 on pull when branch does not exist Jan 15, 2025
@BlumMichael BlumMichael changed the title Fix (STRINGS-564) - CLI do not exit with 0 on pull when branch does not exist Fix(cli) - CLI do not exit with 0 on pull when branch does not exist Jan 15, 2025
@BlumMichael BlumMichael changed the title Fix(cli) - CLI do not exit with 0 on pull when branch does not exist fix(cli): CLI do not exit with 0 on pull when branch does not exist Jan 15, 2025
@BlumMichael BlumMichael force-pushed the STRINGS-564-cli-do-not-exist-with-0-on-pull-when-branch-does-not-exist branch from a9965d7 to 3a4bcbf Compare January 15, 2025 09:20
@BlumMichael BlumMichael requested a review from a team January 15, 2025 09:37
@BlumMichael BlumMichael merged commit e7d8c43 into master Jan 15, 2025
11 checks passed
@BlumMichael BlumMichael deleted the STRINGS-564-cli-do-not-exist-with-0-on-pull-when-branch-does-not-exist branch January 15, 2025 10:06
@phrase-bot phrase-bot mentioned this pull request Jan 15, 2025
Merged
@BlumMichael BlumMichael mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jablan jablan jablan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BlumMichael @jablan