Skip to content

Conversation

@TonsnakeLin
Copy link
Contributor

@TonsnakeLin TonsnakeLin commented Mar 28, 2022

Signed-off-by: TonsnakeLin lpbgytong@163.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#30659

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 28, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn March 28, 2022 13:59
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2022

CLA assistant check
All committers have signed the CLA.

@TonsnakeLin
Copy link
Contributor Author

@en-jin19 en-jin19 self-assigned this Mar 29, 2022
@en-jin19 en-jin19 added translation/doing This PR’s assignee is translating this PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. v6.0 This PR/issue applies to TiDB v6.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 29, 2022
TonsnakeLin and others added 2 commits March 29, 2022 10:21
Co-authored-by: Enwei <jinenwei@pingcap.com>
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@TomShawn
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@TonsnakeLin Please sign the CLA. Thanks!

TonsnakeLin and others added 2 commits March 29, 2022 20:43
Co-authored-by: Enwei <jinenwei@pingcap.com>
Signed-off-by: TonsnakeLin <lpbgytong@163.com>
@en-jin19 en-jin19 added for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed v6.0 This PR/issue applies to TiDB v6.0. labels Mar 30, 2022
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Oreoxmt Oreoxmt closed this May 25, 2022
@Oreoxmt Oreoxmt reopened this May 25, 2022
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 918b457

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@ti-chi-bot ti-chi-bot merged commit 7164cf1 into pingcap:master May 25, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9586.

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 1, 2022
- 创建方式:
当二级唯一索引 `uk((tidb_shard(a)), a))` 的索引字段 `a` 上存在因单调递增或递减而产生的热点时,索引的前缀 `tidb_shard(a)` 会打散热点,从而提升集群扩展性。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话说的像是触发场景?并没有说如何创建

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9670 已提 PR 添加创建方式的说明“使用 uk((tidb_shard(a)), a)) 为字段 a 创建一个 SHARD INDEX。”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.1 This PR/issue applies to TiDB v6.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants