Skip to content

zh,en: add feature gates doc#3026

Merged
ti-chi-bot[bot] merged 10 commits intopingcap:mainfrom
liubog2008:liubo02/add-feature-gates
Dec 3, 2025
Merged

zh,en: add feature gates doc#3026
ti-chi-bot[bot] merged 10 commits intopingcap:mainfrom
liubog2008:liubo02/add-feature-gates

Conversation

@liubog2008
Copy link
Copy Markdown
Member

@liubog2008 liubog2008 commented Nov 28, 2025

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • main (the latest development version for v2.x)
  • v2.0 (TiDB Operator 2.0 versions)
  • release-1.x (the latest development version for v1.x)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@liubog2008
zh,en: add feature gates doc
6306999 
Signed-off-by: liubo02 <liubo02@pingcap.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2025
@Oreoxmt Oreoxmt self-assigned this Nov 28, 2025
@Oreoxmt Oreoxmt self-requested a review November 28, 2025 08:08
@Oreoxmt Oreoxmt added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Nov 28, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 28, 2025
fgksgf
fgksgf reviewed Nov 28, 2025
View reviewed changes
en/feature-gates.md Outdated

### DisablePDDefaultReadinessProbe

Rolling Update: [PD]
Copy link
Copy Markdown
Member

@fgksgf fgksgf Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the table?

Copy link
Copy Markdown
Member Author

@liubog2008 liubog2008 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe too many components?

Copy link
Copy Markdown
Member

@fgksgf fgksgf Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, we may need explain Rolling Update: [PD] clearly, like "Enable/disable the feature requires restarting PD"

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2025
liubog2008 and others added 2 commits November 28, 2025 16:44
@liubog2008 @fgksgf
Apply suggestions from code review
64df287 
Co-authored-by: Hoshea <fgksgf@gmail.com>
@liubog2008
fix lint and address comments
e184b89 
Signed-off-by: liubo02 <liubo02@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 28, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Oreoxmt
Oreoxmt reviewed Dec 2, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Dec 2, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Dec 2, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Dec 2, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Dec 2, 2025
View reviewed changes
liubog2008 and others added 4 commits December 2, 2025 16:07
@liubog2008 @Oreoxmt
Apply suggestions from code review
abbbf2e 
Co-authored-by: Aolin <aolinz@outlook.com>
@liubog2008 @Oreoxmt
Apply suggestions from code review
b5f33bd 
Co-authored-by: Aolin <aolinz@outlook.com>
@liubog2008 @Oreoxmt
Apply suggestion from @Oreoxmt
472f963 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
make ci happy
632d25b
@Oreoxmt Oreoxmt added the v2.0 This PR/issue applies to TiDB Operator v2.0. label Dec 2, 2025
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Dec 2, 2025

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai December 2, 2025 09:36
qiancai
qiancai reviewed Dec 2, 2025
View reviewed changes
zh/feature-gates.md Outdated

- 通常已经过长期和大规模测试。
- 默认开启。
- 不支持关闭。
Copy link
Copy Markdown
Collaborator

@qiancai qiancai Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 不支持关闭。
- 不支持通过特性门控关闭。

Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liubog2008 PTAL

qiancai
qiancai approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-28 08:42:54.6471298 +0000 UTC m=+865138.296324247: ☑️ agreed by csuzhangxc.
  • 2025-12-03 02:27:34.01030369 +0000 UTC m=+403198.824081252: ☑️ agreed by qiancai.

@Oreoxmt Oreoxmt force-pushed the liubo02/add-feature-gates branch from e58c873 to 9fb0ea9 Compare December 3, 2025 02:55
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Dec 3, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit 5927d80 into pingcap:main Dec 3, 2025
14 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 3, 2025

In response to a cherrypick label: new pull request created to branch release-2.0: #3029.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2025
Merged
8 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2025
@ti-chi-bot
zh,en: add feature gates doc (#3026) (#3029)
b2df4c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@qiancai qiancai qiancai approved these changes

+1 more reviewer

@fgksgf fgksgf fgksgf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

approved lgtm needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v2.0 This PR/issue applies to TiDB Operator v2.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liubog2008 @Oreoxmt @ti-chi-bot @csuzhangxc @fgksgf @qiancai