Skip to content

zh,en: add feature gates doc #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

zh,en: add feature gates doc #3026

wants to merge 3 commits into from

Conversation

@liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Nov 28, 2025

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • main (the latest development version for v2.x)
  • v2.0 (TiDB Operator 2.0 versions)
  • release-1.x (the latest development version for v1.x)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2025
@Oreoxmt Oreoxmt self-assigned this Nov 28, 2025
@Oreoxmt Oreoxmt self-requested a review November 28, 2025 08:08
@Oreoxmt Oreoxmt added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Nov 28, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 28, 2025
fgksgf
fgksgf reviewed Nov 28, 2025
View reviewed changes
en/feature-gates.md Outdated

### DisablePDDefaultReadinessProbe

Rolling Update: [PD]
Copy link
Member

@fgksgf fgksgf Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the table?

Copy link
Member Author

@liubog2008 liubog2008 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe too many components?

Copy link
Member

@fgksgf fgksgf Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, we may need explain Rolling Update: [PD] clearly, like "Enable/disable the feature requires restarting PD"

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-28 08:42:54.6471298 +0000 UTC m=+865138.296324247: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

+1 more reviewer

@fgksgf fgksgf fgksgf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liubog2008 @csuzhangxc @fgksgf @Oreoxmt