Update welcome message for first-time contributors #6447
Conversation
@eeshaanSA output of my fork of this workflow
|
|
Please be specific about what it fixes. 'A typo' sounds vague. |
|
@eeshaanSA The previous PR was merged , I typo here is that the workflow had a indentation error which was leading it to failure due to wrong yaml file |
|
Your repo is outdated. Please update it. It should only change the indentation. It is probably missing that one commit I made in the end. PTAL. |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
Ayushmore1214
force-pushed
the
patch-3
branch
from
a547993 to
41e38ac
Compare
|
Done , I guess we are good to go now |
| ### DCO Sign-off | ||
| All commits must include a \`Signed-off-by\` line to comply with the Developer Certificate of Origin (DCO). | ||
|
|
||
| In case you forget to sign-off your commit(s), follow these steps: |
There was a problem hiding this comment.
This is the change I proposed. Please copy as it is.
| ### DCO Sign-off | ||
| All commits must include a \`Signed-off-by\` line to comply with the Developer Certificate of Origin (DCO). | ||
| If you forgot, you can fix it like this: |
| return; | ||
| } | ||
| // Construct the welcome message |
There was a problem hiding this comment.
Ideally no , lets remove it
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
|
@Ayushmore1214, we need something for first issues as well. Maybe. |
@eeshaanSA lets open up a issue for this on what do we need exactly |
3 participants
What this PR does: This PR fixes a small typo in the workflow which was leading to make the workflow fail frequently
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: