-
Notifications
You must be signed in to change notification settings - Fork 229
Update welcome message for first-time contributors #6447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ayushmore1214
wants to merge
3
commits into
pipe-cd:master
Choose a base branch
from
Ayushmore1214:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−48
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ permissions: | |
| jobs: | ||
| welcome: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Welcome first-time contributor | ||
| uses: actions/github-script@v7 | ||
|
|
@@ -36,54 +35,54 @@ jobs: | |
| return; | ||
| } | ||
|
|
||
| // Construct the welcome message | ||
| const body = `👋 Hi @${prAuthor}, welcome to **PipeCD** and thanks for opening your first pull request! | ||
|
|
||
| We’re really happy to have you here 🚀 | ||
| Before your PR gets merged, please check a few important things below. | ||
|
|
||
| --- | ||
|
|
||
| ### Helpful resources | ||
| - Contributing guide: https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md | ||
| - Development setup: https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md#development | ||
|
|
||
| --- | ||
|
|
||
| ### DCO Sign-off | ||
| All commits must include a \`Signed-off-by\` line to comply with the Developer Certificate of Origin (DCO). | ||
|
|
||
| In case you forget to sign-off your commit(s), follow these steps: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the change I proposed. Please copy as it is. |
||
|
|
||
| For the last commit: | ||
| \`\`\`bash | ||
| git commit --amend --signoff | ||
| git push --force-with-lease | ||
| \`\`\` | ||
|
|
||
| For multiple commits: | ||
| \`\`\`bash | ||
| git rebase --signoff origin/master | ||
| git push --force-with-lease | ||
| \`\`\` | ||
|
|
||
| --- | ||
|
|
||
| ### Run checks locally | ||
| Before pushing updates, please run: | ||
| \`\`\`bash | ||
| make check | ||
| \`\`\` | ||
| This runs the same checks as CI and helps catch issues early. | ||
|
|
||
| --- | ||
|
|
||
| ### 💬 Need help? | ||
| If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the **#pipecd** channel. | ||
| You can get your Slack invite from: https://communityinviter.com/apps/cloud-native/cncf | ||
|
|
||
|
|
||
| Thanks for contributing to PipeCD! ❤️ | ||
| `; | ||
|
|
||
| We’re really happy to have you here 🚀 | ||
|
|
||
| Before your PR gets merged, please check a few important things below. | ||
|
|
||
| --- | ||
|
|
||
| ### Helpful resources | ||
| - Contributing guide: https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md | ||
| - Development setup: https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md#development | ||
|
|
||
| --- | ||
|
|
||
| ### DCO Sign-off | ||
| All commits must include a \`Signed-off-by\` line to comply with the Developer Certificate of Origin (DCO). | ||
|
|
||
| If you forgot, you can fix it like this: | ||
|
||
|
|
||
| **For the last commit:** | ||
| \`\`\`bash | ||
| git commit --amend --signoff | ||
| git push --force-with-lease | ||
| \`\`\` | ||
|
|
||
| **For multiple commits:** | ||
| \`\`\`bash | ||
| git rebase --signoff origin/master | ||
| git push --force-with-lease | ||
| \`\`\` | ||
|
|
||
| --- | ||
|
|
||
| ### Run checks locally | ||
| Before pushing updates, please run: | ||
| \`\`\`bash | ||
| make check | ||
| \`\`\` | ||
| This runs the same checks as CI and helps catch issues early. | ||
|
|
||
| --- | ||
|
|
||
| ### 💬 Need help? | ||
| If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the **#pipecd** channel. | ||
| You can get your Slack invite from: https://communityinviter.com/apps/cloud-native/cncf | ||
|
|
||
| Thanks for contributing to PipeCD! ❤️`; | ||
|
|
||
| await github.rest.issues.createComment({ | ||
| owner, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally no , lets remove it