Various fixes, cleanup, performance improvements, QoL#86
Merged
Conversation
7354f5a to
04d4eeb
Compare
6b1df21 to
8ab8edd
Compare
This operation does nothing and only wastes performance. This commit lowers the cpu usage of the process from 180% (per core) to 160%.
This caused the AssetBrowser preview to re-render continuously.
f60f6d0 to
61195a7
Compare
LazyBone2017
approved these changes
Mar 10, 2025
Collaborator
LazyBone2017
left a comment
There was a problem hiding this comment.
Debug Window Works
Gizmos are placed correctly
Increased defaults are there
keybinds are visible
deletion of mouse picked object works
memory usage ~270MB
This barely affects performance as we can only merge 144 meshes currently. However, this might be improved in the future when textures are loaded in texture atlases or array textures.
Sometimes, the outlines would take on the shape of trees, because the tree mask texture was still bound to the texture_opacity sampler.
Previously, the id of each TreeNode was incremental which resulted in ids changing when nodes where moved.
0d85f06 to
92d2be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a disjointed mess of multiple fixes, performance improvements and style changes. It does way too much for one PR, however, I originally just wanted to bundle some very small changes, and it kind of escalated.
Scene save files from the main branch are not compatible and will result in a broken scene.
Memory / Performance:
QoL:
Other stuff:
Texture::m_idtoTexture::id. Only private members should be prefixed withm_and this is just the instance that I really noticed. However there are more occurrences I didn't fix. Maybe I should not bother and remove the commit?