CMakeLists.txt: read version from version.mak instead of hardcoding it#4896
Open
CMakeLists.txt: read version from version.mak instead of hardcoding it#4896
Conversation
Agent-Logs-Url: https://github.com/pjsip/pjproject/sessions/f1999c8c-3dc4-48e1-8205-297524e64b8d Co-authored-by: sauwming <17044930+sauwming@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pjsip/pjproject/sessions/f1999c8c-3dc4-48e1-8205-297524e64b8d Co-authored-by: sauwming <17044930+sauwming@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update version number in CMakeLists.txt from version.mak
CMakeLists.txt: read version from version.mak instead of hardcoding it
Mar 30, 2026
sauwming
approved these changes
Mar 30, 2026
nanangizz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txthadVERSION 2.15hardcoded, causing it to drift from the authoritative version defined inversion.mak(currently 2.16).Description
Parse
PJ_VERSION_MAJOR,PJ_VERSION_MINOR, andPJ_VERSION_REVfromversion.makat configure time and pass the result toproject():version.makis already the single source of truth for versioning (used bysetup.py). The suffix (e.g.-dev) is intentionally excluded since CMakeVERSIONonly accepts numeric components.Motivation and Context
CMakeLists.txtversion was stale (2.15 vs 2.16) and would require manual synchronization on every release. This change eliminates that toil.How Has This Been Tested?
Verified
cmake -S . -B buildproducesCMAKE_PROJECT_VERSION=2.16matchingversion.mak.Screenshots (if appropriate):
Types of changes
Checklist:
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.