Skip to content

CMakeLists.txt: read version from version.mak instead of hardcoding it #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sauwming merged 3 commits into from
Mar 30, 2026
Merged

CMakeLists.txt: read version from version.mak instead of hardcoding it #4896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db64f4
Initial plan
Copilot Mar 30, 2026
06ad241
CMakeLists.txt: read version from version.mak instead of hardcoding it
Copilot Mar 30, 2026
efac82b
Remove accidentally committed cmake system info files; add to .gitignore
Copilot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ tests/fuzz/*.o
*/docs/latex/
*/docs/*.tag

# CMake stuff
__cmake_systeminformation/

# Coverity scan stuff
cov-int/
getversion.mak
Expand Down
20 changes: 19 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,25 @@
cmake_minimum_required(VERSION 3.28...4.0)

# Read version from version.mak
file(STRINGS "${CMAKE_CURRENT_SOURCE_DIR}/version.mak" _version_lines)
foreach(_line IN LISTS _version_lines)
if(_line MATCHES "^export PJ_VERSION_MAJOR[ \t]*:=[ \t]*([0-9]+)")
set(_pj_ver_major "${CMAKE_MATCH_1}")
elseif(_line MATCHES "^export PJ_VERSION_MINOR[ \t]*:=[ \t]*([0-9]+)")
set(_pj_ver_minor "${CMAKE_MATCH_1}")
elseif(_line MATCHES "^export PJ_VERSION_REV[ \t]*:=[ \t]*([0-9]+)")
set(_pj_ver_rev "${CMAKE_MATCH_1}")
endif()
endforeach()
# CMake VERSION field only accepts numeric components
if(_pj_ver_rev)
set(_pj_cmake_version "${_pj_ver_major}.${_pj_ver_minor}.${_pj_ver_rev}")
else()
set(_pj_cmake_version "${_pj_ver_major}.${_pj_ver_minor}")
endif()

project(pjproject
VERSION 2.15
VERSION ${_pj_cmake_version}
DESCRIPTION "Multimedia communication library"
HOMEPAGE_URL "http://www.pjsip.org"
LANGUAGES C CXX
Expand Down
Loading