Added missing descriptions and some minor changes in Schema#654
Merged
BrapiCoordinatorSelby merged 11 commits intobrapi-V2.1from Nov 18, 2025
Merged
Conversation
jloux-brapi
reviewed
Oct 30, 2025
| } | ||
| }, | ||
| "CrossAttribute": { | ||
| "description": "An attribute of a Cross.", |
Contributor
There was a problem hiding this comment.
Should we include what an attribute actually means in the context of a Cross in this description?
Contributor
Author
There was a problem hiding this comment.
Yes, but I don't have any examples :(
| { | ||
| "$defs": { | ||
| "GermplasmAttribute": { | ||
| "description": "Germplasm \"attributes\" are simply-inherited characteristics (characterization descriptors) that are not environment-dependent but \ninherent in the germplasm line. They include genes, QTLs, and genetic \"traits\" like wheat grain \nhardness. They are often evaluated by genotyping for diagnostic markers.", |
Contributor
There was a problem hiding this comment.
Same kind of description would be great for CrossAttribute, as indicated in review above.
| } | ||
| }, | ||
| "EventParameter": { | ||
| "description": "A parameter associated with an event.", |
Contributor
There was a problem hiding this comment.
Maybe we can given an example parameter here.
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Contributor
Author
|
We just need some better descriptions for CrossAttribute and EventParameter, with some examples? |
…plantbreeding/BrAPI into 653-missing-descriptions-in-v21-and-v22 # Conflicts: # Specification/BrAPI-Schema/BrAPI-Germplasm/PlannedCross.json # Specification/BrAPI-Schema/BrAPI-Phenotyping/ObservationUnit.json # Specification/BrAPI-Schema/BrAPI-Phenotyping/Scale.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.