feat: implement secret filed & copy feature #126
+461
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrajniak
requested changes
Nov 10, 2025
projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.html
Show resolved
Hide resolved
| }) | ||
| export class SecretValueComponent { | ||
| value = input.required<string>(); | ||
| maskedValue = computed(() => '*'.repeat(this.value().length || 8)); |
Collaborator
There was a problem hiding this comment.
or we can always have 8
Collaborator
Author
There was a problem hiding this comment.
I thought about this. But then if the value would be toolong when you hover to secret field it will show actual value and cell would shift
| {{ value() }} | ||
| } @else if (displayAsSecret()) { | ||
| <wc-secret-value [value]="value()"></wc-secret-value> | ||
| } @else { |
Collaborator
There was a problem hiding this comment.
here we can have logic all the way down wiht the if else withouth nested if
projects/wc/src/app/components/generic-ui/value-cell/value-cell.component.ts
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/value-cell/value-cell.component.ts
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.