-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement secret filed & copy feature #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sobyt483
wants to merge
6
commits into
main
Choose a base branch
from
hidden-properties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+651
−203
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
20a429b
feat: implement secret filed & copy feature
Sobyt483 f6af56d
chore: cleanup
Sobyt483 781d8d5
feat: change fieldDefinition interface
Sobyt483 9263c94
feat: add ability to apply label display with other value kind
Sobyt483 559b5ab
fix: fix labelDisplay placement in examples
Sobyt483 7cc3c49
feat: add show/hide toggle icon
Sobyt483 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 0 additions & 10 deletions
10
projects/wc/src/app/components/generic-ui/value-cell/label-value/label-value.component.html
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
...cts/wc/src/app/components/generic-ui/value-cell/label-value/label-value.component.spec.ts
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
projects/wc/src/app/components/generic-ui/value-cell/label-value/label-value.component.ts
This file was deleted.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
...ects/wc/src/app/components/generic-ui/value-cell/secret-value/secret-value.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <span class="secret-value"> | ||
| <span class="value-text"> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need the span in span and I don't see the |
||
| @if (isVisible()) { | ||
| <span class="original">{{ value() }}</span> | ||
| } @else { | ||
| <span class="masked">{{ maskedValue() }}</span> | ||
| } | ||
| </span> | ||
| </span> | ||
10 changes: 10 additions & 0 deletions
10
...ects/wc/src/app/components/generic-ui/value-cell/secret-value/secret-value.component.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| .secret-value { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| gap: 0.25rem; | ||
|
|
||
| .masked { | ||
| transform: translateY(0.2em); | ||
| display: flex; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.