Fixes picking issue in low DPR #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s DPR for improved accuracy
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the picking issue on low DPR (dots-per-inch) displays by adjusting the scale calculation in the getEntityAtPointerEvent function to use PlayCanvas's DPR from the graphicsDevice.
- Update scale factor calculation by incorporating app.graphicsDevice.maxPixelRatio.
- Minor code cleanup in picker.tsx.
Comments suppressed due to low confidence (1)
packages/lib/src/utils/picker.tsx:65
- The second 'return null' statement is unreachable after returning the mesh instance. Please remove it to clean up the control flow.
return null
commit: |
… to streamline code execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scale calculation in getEntityAtPointerEvent to use PlayCanvas's DPR. This was not working on some screens where the dpr < 1 (rotated screens)