Skip to content

Fixes picking issue in low DPR #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklundin merged 2 commits into from
May 8, 2025
Merged

Fixes picking issue in low DPR #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91b86e
Update scale calculation in getEntityAtPointerEvent to use PlayCanvas…
marklundin May 8, 2025
955de4f
Remove redundant return statement in getEntityAtPointerEvent function…
marklundin May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/lib/src/utils/picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ const getEntityAtPointerEvent = async (app : AppBase, picker: Picker, rect: DOMR
const x = e.clientX - rect.left;
const y = e.clientY - rect.top;

// Account for canvas scaling
const scaleX = canvas.width / rect.width;
const scaleY = canvas.height / rect.height;
// Scale calculation using PlayCanvas's DPR
const scaleX = canvas.width / (rect.width * app.graphicsDevice.maxPixelRatio);
const scaleY = canvas.height / (rect.height * app.graphicsDevice.maxPixelRatio);

// prepare the picker and perform picking
try {
Expand All @@ -67,7 +67,6 @@ const getEntityAtPointerEvent = async (app : AppBase, picker: Picker, rect: DOMR
if (!meshInstance) return null

return meshInstance?.node as Entity;
return null
} catch {
// The picker can fail if the camera is not active or the canvas is not visible
return null;
Expand Down
Loading