Skip to content

Conversation

@marklundin
Copy link
Collaborator

Removes the deprecated resetZoom() function

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 95ae1c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@playcanvas/blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marklundin marklundin self-assigned this Sep 11, 2025
@marklundin marklundin added bug Something isn't working Blocks labels Sep 11, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@playcanvas/blocks@242
npm i https://pkg.pr.new/@playcanvas/react@242

commit: 95ae1c4

@marklundin marklundin requested a review from Copilot September 11, 2025 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated resetZoom() method from the camera API in the splat viewer component. The change updates the camera controls to use a simplified focus call instead of separate focus and resetZoom operations.

Key Changes

  • Removed call to deprecated resetZoom() method in CameraController
  • Updated focus() method call with hardcoded true parameter
  • Added changeset documenting the API update

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/blocks/src/splat-viewer/smart-camera.tsx Removes deprecated resetZoom method call and updates focus method parameters
.changeset/sixty-shrimps-listen.md Documents the camera API change for release notes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marklundin marklundin marked this pull request as ready for review September 11, 2025 18:31
@marklundin marklundin merged commit f6bf216 into main Sep 11, 2025
6 checks passed
@marklundin marklundin deleted the fix-splat-viewer-camera-api branch September 11, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocks bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants