Skip to content

fix(camera): update camera API by removing resetZoom method #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklundin merged 2 commits into from
Sep 11, 2025
Merged

fix(camera): update camera API by removing resetZoom method #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
185ede4
fix(camera): update camera API by removing resetZoom method
marklundin Sep 11, 2025
95ae1c4
fix(camera): change focus method to prevent camera reset during updates
marklundin Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-shrimps-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@playcanvas/blocks": patch
---

Updated camera api (removed resetZoom)
4 changes: 2 additions & 2 deletions packages/blocks/src/splat-viewer/smart-camera.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ function CameraController({ focus = [0, 0, 0], distance = 0, animate = false, ..
// @ts-expect-error CameraControls is not defined in the script
const controls = (entity.script?.cameraControls || entity.script?._CameraControls) as CameraControls;
if (controls) {
controls.focus(new Vec3().fromArray(focus), null, animate);
controls.resetZoom(distance, animate);
controls.focus(new Vec3().fromArray(focus), false);

}
}, [focus, distance, animate]);

Expand Down
Loading