Suppress Engine deprecation warnings #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warnings during property retrieval
…ation for @playcanvas/react
🦋 Changeset detectedLatest commit: e7270a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
mvaligursky
approved these changes
Sep 23, 2025
mvaligursky
left a comment
mvaligursky
left a comment
There was a problem hiding this comment.
Seems ok.
This will not hide other useful warnings I assume, as it's used only in the validation time?
Is this still needed? playcanvas/engine#7964
Collaborator
Author
|
Yep it only happens at startup an only overriding the warn, so there's a chance it might miss some warnings. Something like #7964 would be more robust, but this will be ok for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of deprecated properties in the engine which issues warnings. This PR simply supresses those warnings during validation.