Skip to content

Suppress Engine deprecation warnings #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklundin merged 2 commits into from
Sep 23, 2025
Merged

Suppress Engine deprecation warnings #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abad5a5
Enhance getPseudoPublicProps function to temporarily silence console …
marklundin Sep 23, 2025
e7270a6
Implement changeset to prevent deprecation warnings during prop valid…
marklundin Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-mails-obey.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@playcanvas/react": patch
---

Prevents deprecation warnings flooding the console during prop validation
8 changes: 8 additions & 0 deletions packages/lib/src/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@ export function getPseudoPublicProps(container: Record<string, unknown>): Record

// If it's a getter/setter property, try to get the value
if (descriptor.get) {
const originalWarn = console.warn;
try {
// Temporarily silence the console
console.warn = () => {};

const value = descriptor.get.call(container);
// Create a shallow copy of the value to avoid reference issues
const safeValue = value !== null && typeof value === 'object'
Expand All @@ -300,6 +304,10 @@ export function getPseudoPublicProps(container: Record<string, unknown>): Record
isDefinedWithSetter: hasSetter
};
}
finally {
// Restore the console
console.warn = originalWarn;
}
} else if (hasSetter) {
// Setter-only property
result[key] = {
Expand Down
Loading