Provide the content for the Diazo theming part#1870
Merged
stevepiercy merged 28 commits intoclassic-ui-theming-reorg-1645from Feb 26, 2025
Merged
Provide the content for the Diazo theming part#1870stevepiercy merged 28 commits intoclassic-ui-theming-reorg-1645from
stevepiercy merged 28 commits intoclassic-ui-theming-reorg-1645from
Conversation
* Fix broken references - `link.svg` - `_inc/_install-browser-reqs-volto.md` * Fix linkcheck to bobtemplates * Update tip submodules/volto * Fix link
erral
force-pushed
the
erral-diazo-docs
branch
from
133787b to
676f204
Compare
- Add note update getting help for choosing a theming method
stevepiercy
requested changes
Feb 24, 2025
Contributor
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
I restructured the Diazo doc to present the critical path first, followed by advice. It flows a little better, but there are still some issues with it, namely a first-timer would have no clue what to do after reading this.
explain the purpose of each file created when addin a theme
Link to Diazo docs.
- Reuse a sentence from Diazo docs that fills a critical gap in the introduction. - Convert list of files descriptions into a definition list
stevepiercy
requested changes
Feb 25, 2025
Contributor
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Almost there! A couple of questions regarding the registry.xml file for TinyMCE.
# Conflicts: # docs/classic-ui/theming/index.md
petschki
reviewed
Feb 26, 2025
stevepiercy
approved these changes
Feb 26, 2025
Contributor
stevepiercy
merged commit 9747612
into
classic-ui-theming-reorg-1645
2 of 3 checks passed
stevepiercy
added a commit
that referenced
this pull request
Feb 26, 2025
* Reorganize Classic UI Theming part * Update docs/classic-ui/theming/settings-ttw.md Co-authored-by: Peter Mathis <petschki@users.noreply.github.com> * Update settings-ttw.md * Fix broken link * Add guide for choosing one Classic UI theme or another, thanks to @jensens! * Provide the content for the Diazo theming part (#1870) * Update tips submodules/plone.api submodules/volto * Update tip submodules/volto * Fix broken references (#1868) * Fix broken references - `link.svg` - `_inc/_install-browser-reqs-volto.md` * Fix linkcheck to bobtemplates * Update tip submodules/volto * Fix link * Update tip submodules/plone.api * Update tip submodules/volto * initial structure of Theming with Diazo * more doc * initial structure of Theming with Diazo * more doc * - Add diazo to toctree - Add note update getting help for choosing a theming method * Clean up grammar, one sentence per line, MyST syntax * Add language * Move concepts and advice into a new Theme development advice section * Minor tweaks * Rename section to reflect its content * Adjust heading level * Update diazo.md explain the purpose of each file created when addin a theme * Update diazo.md Link to Diazo docs. * Update diazo.md * - Make first mention of Diazo a term, already existing in the Glossary - Reuse a sentence from Diazo docs that fills a critical gap in the introduction. - Convert list of files descriptions into a definition list * Tweak markup * add tinymce templates docs * Tidy up * Add a label and important admonition about Template plugin removal in TinyMCE 7.0 * Remove important admonition about Template plugin --------- Co-authored-by: Steve Piercy <web@stevepiercy.com> * Fix broken link --------- Co-authored-by: Peter Mathis <petschki@users.noreply.github.com> Co-authored-by: Mikel Larreategi <mlarreategi@codesyntax.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be seen as part of #1645
📚 Documentation preview 📚: https://plone6--1870.org.readthedocs.build/