fix language identifier for language file#1432
Merged
Conversation
1letter
force-pushed
the
fix-i18n-select2
branch
from
c0487f6 to
4392ed5
Compare
petschki
force-pushed
the
fix-i18n-select2
branch
from
4392ed5 to
f2631a7
Compare
petschki
requested changes
Feb 14, 2025
src/pat/select2/select2.js
Outdated
Comment on lines
113
to
120
| var lang = this.options.language; | ||
| // Fix for country specific languages | ||
| if (lang.split("-").length > 1) { | ||
| lang = | ||
| lang.split("-")[0] + | ||
| "-" + | ||
| lang.split("-")[1].toUpperCase(); | ||
| } |
Member
There was a problem hiding this comment.
instead of calling .split() 3 times I'd suggest:
Suggested change
| var lang = this.options.language; | |
| // Fix for country specific languages | |
| if (lang.split("-").length > 1) { | |
| lang = | |
| lang.split("-")[0] + | |
| "-" + | |
| lang.split("-")[1].toUpperCase(); | |
| } | |
| let lang = this.options.language.split("-"); | |
| // Fix for country specific languages | |
| lang = (lang.length > 1) ? `${lang[0]}-${lang[1]}` : lang[0]; |
petschki
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the generated filename for language files in select2