Skip to content

fix language identifier for language file #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petschki merged 3 commits into from
Feb 14, 2025
Merged

fix language identifier for language file #1432

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70fcee0
fix language identifier for language file
1letter Feb 14, 2025
f2631a7
fix(pat select2): fix language identifier for select2 language files
1letter Feb 14, 2025
84a5a1f
fix(pat select2): add improvements from review
1letter Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/pat/select2/select2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,11 @@ export default Base.extend({
await import("select2");
try {
// Don't load "en" which is the default where no separate language file exists.
if (this.options.language && this.options.language !== "en") {
await import(`select2/select2_locale_${this.options.language}`);
if (this.options.language && this.options.language !== "en" && !this.options.language.startsWith("en")) {
let lang = this.options.language.split("-");
// Fix for country specific languages
lang = (lang.length > 1) ? `${lang[0]}-${lang[1]}` : lang[0];
await import(`select2/select2_locale_${lang}`);
}
} catch {
console.warn("Language file could not be loaded", this.options.language);
Expand Down