Conversation
|
Looks good, thanks. Clearly it's been a long while since I touched this. I need to do some updates to the CI setup, get that working again. Then, please remove the version bump from this PR, and I'll do it separately after merging this. |
This reverts commit a2f2ff2. Per ploxiln#83 (comment)
Revert "Bump version"
|
Removed the version bump. Happy to merge master once you get CI figured out, LMK. |
|
I merged the CI updates ... and dropping python2.7 support and more 😬 ... in #56 |
| except ImportError: | ||
| import queue as Queue | ||
| from multiprocessing import Process | ||
| from multiprocessing.context import ForkProcess |
There was a problem hiding this comment.
I think this import will fail on windows, which will cause fabric to fail to start (even if parallel isn't used)
| # Attach exit codes now that we're all done & have joined all jobs | ||
| for job_name, exit_code in self._completed: | ||
| if isinstance(job, Process): | ||
| if isinstance(job, ForkProcess): |
There was a problem hiding this comment.
This line doesn't really make sense here anyway: job is from the last iteration of for id, job in enumerate(self._running): above ...
|
closing in favor of #88 (it would be great if you can test that one!) |
|
Thank you. Seems to work well in basic testing on macOS. I'll get it merged into |
|
Thanks! I've tested parallel with #88 a bit on linux before merging it (but only with a few targets). |
2 participants
This fixes parallel mode in Python 3.8+ and closes #27. We have been using the change for production operations at Expensify and it works great ✅ Credit to @Stealthii for the code here