Skip to content

fix(issue): waiting status is not being computed correctly #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 2 commits into from
May 22, 2025
Merged

fix(issue): waiting status is not being computed correctly #3597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
046696b
fix(issue): waiting status is not being computed correctly
MyvTsv May 20, 2025
6ee0250
review
MyvTsv May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions inc/formanswer.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2005,12 +2005,15 @@ public function getAggregatedStatus(): ?int {
continue;
}
$ticketStatus = PluginFormcreatorCommon::getTicketStatusForIssue($generatedTarget);
if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_WAITING) {
// Ignore tickets refused or pending for validation
// getTicketStatusForIssue() does not returns STATUS_ACCEPTED
if ($ticketStatus > PluginFormcreatorFormAnswer::STATUS_WAITING) {
continue;
}

// force pending approval status to be seen from to_validate dashboard
if ($ticketStatus == PluginFormcreatorFormAnswer::STATUS_WAITING) {
return PluginFormcreatorFormAnswer::STATUS_WAITING;
}

if ($ticketStatus == CommonITILObject::WAITING) {
$aggregatedStatus = CommonITILObject::WAITING;
break;
Expand Down