fix(issue): waiting status is not being computed correctly

[MyvTsv]

Changes description

If a target that was linked to an issue had a pending validation request, the issue would not have the status “validation pending” but the status “assigned”.

Checklist

Please check if your PR fulfills the following specifications:

• Tests for the changes have been added
• Docs have been added/updated

References

Closes !37694

[btry]

This change requires to check the sync issues sql query. It very likely needs to reflect it.

[stonebuzz]

If I'm not mistaken, it's already the case.

new QueryExpression("IF(`$ticketTable`.`global_validation` IN ('" . CommonITILValidation::NONE . "', '" . CommonITILValidation::ACCEPTED . "'),
   `$ticketTable`.`status`,
   IF(`$ticketTable`.`status` IN ('" . CommonITILObject::SOLVED . "', '" . CommonITILObject::CLOSED . "'),
      `$ticketTable`.`status`,
      IF(`$ticketTable`.`global_validation` = '" . CommonITILValidation::WAITING . "',
         '" . PluginFormcreatorFormAnswer::STATUS_WAITING . "',
         '" . PluginFormcreatorFormAnswer::STATUS_REFUSED . "'
      )
   )
) AS `status`"),

[btry]

yes, it looks good.

[stonebuzz]

waiting customer validation

[MyvTsv]

It's good for customer